add support for datastream lifecycle#724
Merged
tobio merged 1 commit intoelastic:mainfrom Aug 26, 2024
Merged
Conversation
|
💚 CLA has been signed |
tobio
reviewed
Aug 23, 2024
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
Thanks for adding this in. one small change to make this work when lifecycle isn't defined.
Comment on lines
+316
to
+321
| lifecycle, diags := ExpandLifecycle(definedTempl["lifecycle"].(*schema.Set)) | ||
| if diags.HasError() { | ||
| return templ, false, diags | ||
| } | ||
| if lifecycle != nil { | ||
| templ.Lifecycle = lifecycle | ||
| } |
Member
There was a problem hiding this comment.
The tests are failing when lifecycle is not defined in the TF module. I'm pretty sure this should fix it, though it's totally untested.
Suggested change
| lifecycle, diags := ExpandLifecycle(definedTempl["lifecycle"].(*schema.Set)) | |
| if diags.HasError() { | |
| return templ, false, diags | |
| } | |
| if lifecycle != nil { | |
| templ.Lifecycle = lifecycle | |
| } | |
| if lc, ok := definedTempl["lifecycle"]; ok { | |
| lifecycle, diags := ExpandLifecycle(lc.(*schema.Set)) | |
| if diags.HasError() { | |
| return templ, false, diags | |
| } | |
| if lifecycle != nil { | |
| templ.Lifecycle = lifecycle | |
| } | |
| } |
Contributor
Author
There was a problem hiding this comment.
Sorry for mistake. I didn't test newly created index. I fixed it in ExpandLifecycle function.
Member
Contributor
Author
|
I have pushed one more fix. Tests should work now. |
tobio
approved these changes
Aug 26, 2024
Member
tobio
left a comment
tobio
left a comment
There was a problem hiding this comment.
LGTM. Thanks for taking the time to get this added in!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #673